Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/app-defaults/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/core-app-api": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-app-api": "0.1.0",
"@backstage/core-components": "0.8.6",
Comment on lines +35 to +36
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependencies should use the workspace:^ protocol to ensure they use the local packages from the monorepo. Pinning to old, fixed versions will cause build failures and inconsistencies. For example, @backstage/core-app-api is being downgraded from a local 1.9.1-next.0 to a published 0.1.0.

Suggested change
"@backstage/core-app-api": "0.1.0",
"@backstage/core-components": "0.8.6",
"@backstage/core-app-api": "workspace:^",
"@backstage/core-components": "workspace:^",

"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-permission-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This dependency should also use the workspace:^ protocol. Pinning @backstage/theme to 0.1.1 is a significant downgrade from the monorepo version 0.4.1 and will likely cause issues.

Suggested change
"@backstage/theme": "0.1.1",
"@backstage/theme": "workspace:^",

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1"
},
Expand Down
Loading