Skip to content

[Snyk] Fix for 4 vulnerabilities #11617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 4 vulnerabilities #11617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/todo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.8.6",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Comment on lines +34 to +38
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change introduces a significant downgrade of @backstage/core-components (from a 0.13.x version to 0.8.6) and @backstage/theme (from 0.4.x to 0.1.1). Such a major downgrade is highly likely to introduce breaking changes and cause the plugin to fail at runtime due to API incompatibilities with other @backstage packages that rely on newer versions.

This approach of pinning to old versions also undermines the monorepo's workspace setup, which is designed to ensure version consistency across packages. The correct way to fix these vulnerabilities would be to upgrade the transitive dependencies that are vulnerable, possibly by using resolutions in the root package.json if a direct dependency upgrade is not feasible.

Given the high risk of breakage, this change should be reverted.

Suggested change
"@backstage/core-components": "0.8.6",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading