Skip to content

[Snyk] Fix for 2 vulnerabilities#11627

Closed
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-aca363c595e5e3fede42e0377f0c3d7b
Closed

[Snyk] Fix for 2 vulnerabilities#11627
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-aca363c595e5e3fede42e0377f0c3d7b

Conversation

@q1blue
Copy link
Copy Markdown
Collaborator

@q1blue q1blue commented Feb 2, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/example-todo-list-backend/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Directory Traversal
SNYK-JS-TAR-15127355
  127  
medium severity Uncontrolled Recursion
SNYK-JS-ESLINT-15102420
  45  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Directory Traversal


EntelligenceAI PR Summary

This PR converts workspace protocol dependency references to explicit version numbers in the example-todo-list-backend plugin.

  • Updated @backstage/backend-common to version 0.24.1
  • Updated @backstage/backend-plugin-api to version 0.6.19
  • Updated @backstage/errors to version 0.1.1
  • Updated @backstage/plugin-auth-node to version 0.6.0
  • Changed all dependencies from workspace:^ protocol to pinned versions in package.json

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Feb 2, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by resolving two identified vulnerabilities. It achieves this by upgrading specific @backstage dependencies within the plugins/example-todo-list-backend/package.json file to versions containing the necessary security patches.

Highlights

  • Vulnerability Fixes: This pull request addresses two medium-severity vulnerabilities: Directory Traversal (SNYK-JS-TAR-15127355) and Uncontrolled Recursion (SNYK-JS-ESLINT-15102420).
  • Dependency Updates: Several @backstage dependencies in plugins/example-todo-list-backend/package.json have been updated to specific patched versions to mitigate the identified vulnerabilities.
  • Manual yarn.lock Update Required: A warning indicates that the yarn.lock file was not automatically updated by Snyk and requires manual intervention before merging, especially for projects utilizing Yarn's zero-install feature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix two security vulnerabilities by updating dependencies. However, the proposed changes are problematic for a monorepo environment. They replace workspace:^ dependencies with pinned versions, which can lead to inconsistencies. Most critically, this PR downgrades the @backstage/errors package from version 1.2.1 to 0.1.1, which is a major regression and likely to cause application failures. I've added a comment with a suggestion to revert these changes. The underlying security vulnerabilities should be addressed by updating the packages within the workspace itself, rather than pinning to external versions. Also, please note that the yarn.lock file needs to be manually updated after any dependency changes.

Comment on lines +27 to +31
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/errors": "0.1.1",
"@backstage/plugin-auth-node": "0.6.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Replacing workspace:^ with pinned versions is problematic in a monorepo. It can cause inconsistencies, and it seems to have introduced a critical error here: @backstage/errors is being downgraded from workspace version 1.2.1 to 0.1.1. This is a major regression.

While the other packages are upgraded, this approach of detaching from the workspace is not ideal. The recommended approach is to update the packages within the workspace to versions that contain security fixes, and continue to reference them with workspace:^. These changes should be reverted.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-auth-node": "workspace:^"

@entelligence-ai-pr-reviews
Copy link
Copy Markdown

Walkthrough

This pull request updates the dependency management strategy for the example-todo-list-backend plugin by replacing workspace protocol references with explicit version numbers. Four Backstage packages are affected: backend-common (0.24.1), backend-plugin-api (0.6.19), errors (0.1.1), and plugin-auth-node (0.6.0). This change transitions from workspace-relative dependency resolution to pinned versions, which is typically done to prepare a plugin for standalone distribution, ensure consistent dependency versions across different environments, or facilitate publishing to a package registry.

Changes

File(s) Summary
plugins/example-todo-list-backend/package.json Replaced workspace protocol (workspace:^) with explicit version numbers for four Backstage dependencies: @backstage/backend-common (0.24.1), @backstage/backend-plugin-api (0.6.19), @backstage/errors (0.1.1), and @backstage/plugin-auth-node (0.6.0).

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PKG as package.json
    participant NPM as Package Registry
    
    Note over Dev,NPM: Dependency Version Update
    
    Dev->>PKG: Update dependency versions
    Note right of PKG: @backstage/backend-common: workspace:^ → 0.24.1<br/>@backstage/backend-plugin-api: workspace:^ → 0.6.19<br/>@backstage/errors: workspace:^ → 0.1.1<br/>@backstage/plugin-auth-node: workspace:^ → 0.6.0
    
    Dev->>NPM: Install updated dependencies
    NPM-->>Dev: Dependencies resolved and installed
    
    Note over Dev,NPM: No runtime behavior changes<br/>Only dependency version updates
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Feb 2, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 9, 2026

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Feb 9, 2026
@github-actions github-actions Bot closed this Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants