Skip to content

[Snyk] Security upgrade @backstage/theme from 0.0.0-use.local to 0.1.1#11630

Closed
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-46af829e69fd48729c5ccd7a36d68c0b
Closed

[Snyk] Security upgrade @backstage/theme from 0.0.0-use.local to 0.1.1#11630
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-46af829e69fd48729c5ccd7a36d68c0b

Conversation

@q1blue
Copy link
Copy Markdown
Collaborator

@q1blue q1blue commented Feb 2, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/bazaar/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Directory Traversal
SNYK-JS-TAR-15127355
  127  
medium severity Uncontrolled Recursion
SNYK-JS-ESLINT-15102420
  45  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Directory Traversal


EntelligenceAI PR Summary

This PR pins the @backstage/theme dependency to a specific version in the bazaar plugin package configuration.

  • Modified plugins/bazaar/package.json to change dependency specification
  • Replaced workspace protocol reference (workspace:^) with fixed version 0.1.1
  • Affects dependency resolution behavior in monorepo environments
  • May indicate need for version stability or compatibility workaround

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Feb 2, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Feb 2, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@entelligence-ai-pr-reviews
Copy link
Copy Markdown

Walkthrough

This PR modifies the dependency management for the bazaar plugin by changing how the Backstage theme package is referenced. The update replaces the workspace protocol reference with a pinned version number, moving from dynamic workspace resolution to a fixed version dependency. This change affects how the package resolves dependencies in monorepo environments, potentially addressing version stability requirements or compatibility concerns with the theme package.

Changes

File(s) Summary
plugins/bazaar/package.json Changed @backstage/theme dependency from workspace protocol (workspace:^) to fixed version 0.1.1, pinning the theme package to a specific version instead of using local workspace resolution.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PackageJSON as package.json
    participant PackageManager as Package Manager
    
    Note over Dev,PackageManager: Dependency Version Update
    
    Dev->>PackageJSON: Update @backstage/theme version
    Note right of PackageJSON: Change from workspace:^ to 0.1.1
    
    Dev->>PackageManager: Install dependencies
    PackageManager->>PackageManager: Resolve @backstage/theme@0.1.1
    PackageManager-->>Dev: Dependencies installed
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically created by Snyk, addresses two security vulnerabilities by upgrading the @backstage/theme dependency in the plugins/bazaar plugin. It's important to manually update the yarn.lock file before merging. Users employing Yarn's zero-installs feature should also be aware of a potential need to update their cache directory.

Highlights

  • Dependency Upgrade: The PR upgrades the @backstage/theme dependency in plugins/bazaar/package.json from 0.0.0-use.local to version 0.1.1.
  • Security Fix: This upgrade addresses two vulnerabilities: Directory Traversal (SNYK-JS-TAR-15127355) and Uncontrolled Recursion (SNYK-JS-ESLINT-15102420).
  • Yarn Zero-Installs Note: The PR includes a note for users of Yarn's zero-installs feature, indicating that they may need to run yarn to update the .yarn/cache/ directory.
  • Yarn Lock Update Failed: The PR description includes a warning that the yarn.lock file failed to update and needs to be updated manually before merging.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix two security vulnerabilities by updating the @backstage/theme dependency. However, the proposed change of pinning @backstage/theme to version 0.1.1 in plugins/bazaar/package.json is problematic for this monorepo structure. It replaces a workspace dependency with a fixed version, which is a significant downgrade from the current workspace version (0.4.1) and risks introducing dependency conflicts, runtime errors, and UI inconsistencies. Furthermore, the PR description notes that yarn.lock failed to update, which is another strong indicator that this change is not safe to merge as-is. I've added a critical review comment with a suggestion to revert this change and instead address the underlying vulnerabilities within the @backstage/theme package itself to maintain the integrity of the monorepo's workspace setup.

"@backstage/plugin-catalog": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change pins the @backstage/theme dependency to version 0.1.1, replacing the workspace:^ reference. This is a significant and potentially breaking change in a monorepo setup.

By pinning to a specific version, this package will no longer use the version of @backstage/theme from the local workspace. The version of @backstage/theme within this monorepo is 0.4.1 (as seen in packages/theme/package.json), so this change effectively downgrades the theme package to a much older version (0.1.1).

This can lead to several major issues:

  • Dependency Duplication: You may end up with two different versions of @backstage/theme in your final bundle, increasing its size and complexity.
  • Runtime Errors: If @backstage/theme uses React Context or other singletons, having multiple versions will likely lead to runtime errors.
  • Inconsistent UI: The bazaar plugin will use an older theme, potentially looking different from the rest of the application.
  • Maintenance Overhead: It breaks the linkage of workspace packages, which is a core benefit of using a monorepo.

While the intent is to fix a security vulnerability, this approach is problematic. The correct way to fix this would be to address the vulnerability within the @backstage/theme package itself, for example by updating its transitive dependencies. I recommend reverting this change and investigating the vulnerability within the theme package.

Suggested change
"@backstage/theme": "0.1.1",
"@backstage/theme": "workspace:^",

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 9, 2026

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Feb 9, 2026
@github-actions github-actions Bot closed this Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants