Skip to content

[Snyk] Security upgrade @backstage/theme from 0.0.0-use.local to 0.1.1 #11630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Security upgrade @backstage/theme from 0.0.0-use.local to 0.1.1 #11630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/bazaar/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change pins the @backstage/theme dependency to version 0.1.1, replacing the workspace:^ reference. This is a significant and potentially breaking change in a monorepo setup.

By pinning to a specific version, this package will no longer use the version of @backstage/theme from the local workspace. The version of @backstage/theme within this monorepo is 0.4.1 (as seen in packages/theme/package.json), so this change effectively downgrades the theme package to a much older version (0.1.1).

This can lead to several major issues:

  • Dependency Duplication: You may end up with two different versions of @backstage/theme in your final bundle, increasing its size and complexity.
  • Runtime Errors: If @backstage/theme uses React Context or other singletons, having multiple versions will likely lead to runtime errors.
  • Inconsistent UI: The bazaar plugin will use an older theme, potentially looking different from the rest of the application.
  • Maintenance Overhead: It breaks the linkage of workspace packages, which is a core benefit of using a monorepo.

While the intent is to fix a security vulnerability, this approach is problematic. The correct way to fix this would be to address the vulnerability within the @backstage/theme package itself, for example by updating its transitive dependencies. I recommend reverting this change and investigating the vulnerability within the theme package.

Suggested change
"@backstage/theme": "0.1.1",
"@backstage/theme": "workspace:^",

"@date-io/luxon": "1.x",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading