Skip to content

[Snyk] Fix for 2 vulnerabilities #11631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #11631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/analytics-module-newrelic-browser/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
Comment on lines +25 to +27
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly replaces workspace-protocol versions (workspace:^) with pinned, outdated versions of @backstage packages. This is likely to break the application for several reasons:

  1. Incorrect for Monorepos: In a Yarn workspace monorepo, workspace:^ ensures that packages within the monorepo use the code from each other directly. Pinning to a specific version breaks this and can lead to bundling multiple, incompatible versions of the same package.
  2. Significant Downgrades: The versions being pinned are very old. For example:
    • @backstage/config is pinned to 0.1.1, but the workspace version is 1.0.8.
    • @backstage/core-components is pinned to 0.1.0, but the workspace version is 0.13.4-next.0.
    • @backstage/core-plugin-api is pinned to 0.1.0, but the workspace version is 1.5.3.
      Such large downgrades will almost certainly lead to build failures or runtime errors due to API incompatibilities.
  3. Snyk Warning: The PR description itself warns Failed to update the yarn.lock, please update manually before merging., which indicates that this automated change is problematic.

It's recommended to reject this automated change from Snyk. The underlying vulnerabilities in tar and eslint should be addressed by updating the root dependencies that bring them in (likely @backstage/cli or other development tools) and then running yarn install to regenerate the lockfile correctly.

    "@backstage/config": "workspace:^",
    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^"

"@newrelic/browser-agent": "^1.236.0",
"react-use": "^17.2.4"
},
Expand Down
Loading