Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/sonarqube/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-sonarqube-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change pins the @backstage/theme package to version 0.1.1. However, the version of this package within the monorepo is 0.4.1 (as defined in packages/theme/package.json). This change is effectively a downgrade and breaks the convention of using workspace:^ for internal packages. This can lead to dependency conflicts, unexpected behavior, or build failures. The dependency should remain as "workspace:^" to correctly resolve to the version within the monorepo.

Suggested change
"@backstage/theme": "0.1.1",
"@backstage/theme": "workspace:^",

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading