Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/gocd/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly replaces the workspace:^ protocol with a hardcoded version for @backstage/theme. In a monorepo using Yarn workspaces, workspace:^ ensures that the local package from the workspace is used, promoting consistency. Pinning to a specific, and in this case, much older version (0.1.1) while the workspace version is 0.4.1 will likely lead to build failures, dependency conflicts, or runtime issues. The automated Snyk upgrade appears to have misinterpreted the workspace:^ value. This change should be reverted to maintain the integrity of the monorepo's dependency structure.

Suggested change
"@backstage/theme": "0.1.1",
"@backstage/theme": "workspace:^",

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading