Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/scaffolder-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-scaffolder-common": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/types": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly replaces the workspace dependency with a pinned, outdated version. In this monorepo, @backstage/types is a local package (at version 1.1.0) and should be referenced using the workspace: protocol to ensure consistency. Pinning to version 0.1.1 from the public registry will introduce a very old version of the package, likely causing type mismatches, build failures, or runtime errors.

The automated Snyk pull request does not seem to handle monorepo workspaces correctly. This change should be reverted. The underlying vulnerabilities should be addressed by updating the dependencies within the monorepo structure, not by pinning to an external version.

Suggested change
"@backstage/types": "0.1.1",
"@backstage/types": "workspace:^",

"@backstage/version-bridge": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading