Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/backend-next/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,30 +25,30 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-defaults": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/backend-defaults": "0.1.0",
"@backstage/backend-tasks": "0.6.1",
"@backstage/plugin-adr-backend": "workspace:^",
"@backstage/plugin-app-backend": "workspace:^",
"@backstage/plugin-app-backend": "0.1.1",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-azure-devops-backend": "workspace:^",
"@backstage/plugin-badges-backend": "workspace:^",
"@backstage/plugin-catalog-backend": "workspace:^",
"@backstage/plugin-catalog-backend": "0.1.1",
"@backstage/plugin-catalog-backend-module-unprocessed": "workspace:^",
"@backstage/plugin-devtools-backend": "workspace:^",
"@backstage/plugin-entity-feedback-backend": "workspace:^",
"@backstage/plugin-kubernetes-backend": "workspace:^",
"@backstage/plugin-lighthouse-backend": "workspace:^",
"@backstage/plugin-linguist-backend": "workspace:^",
"@backstage/plugin-permission-backend": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-common": "0.1.0",
"@backstage/plugin-permission-node": "workspace:^",
"@backstage/plugin-scaffolder-backend": "workspace:^",
"@backstage/plugin-scaffolder-backend": "0.1.1",
"@backstage/plugin-search-backend": "workspace:^",
"@backstage/plugin-search-backend-module-catalog": "workspace:^",
"@backstage/plugin-search-backend-module-explore": "workspace:^",
"@backstage/plugin-search-backend-module-techdocs": "workspace:^",
"@backstage/plugin-search-backend-node": "workspace:^",
"@backstage/plugin-techdocs-backend": "workspace:^",
"@backstage/plugin-techdocs-backend": "0.1.1",
Comment on lines +28 to +51
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes are incorrect and will likely break the application.

  1. Incorrectly handling Yarn Workspaces: The workspace:^ protocol is used to link packages within a monorepo. By replacing it with pinned versions, you are breaking this linkage. This package will no longer use the code from the corresponding packages in this repository, but will instead download old versions from the public registry.
  2. Downgrading Dependencies: Most of the version changes are significant downgrades (e.g., @backstage/plugin-app-backend from 0.3.48-next.0 to 0.1.1). This will likely lead to build failures or runtime errors due to missing features or API changes.
  3. Incomplete Fix: As noted in the PR description, yarn.lock was not updated. Without updating the lock file, these dependency changes will not take effect, and the vulnerabilities will remain.

These changes should be reverted. Vulnerabilities in workspace packages should be addressed by updating the source of the vulnerability within the monorepo and then running yarn to update the yarn.lock file.

    "@backstage/backend-defaults": "workspace:^",
    "@backstage/backend-tasks": "workspace:^",
    "@backstage/plugin-adr-backend": "workspace:^",
    "@backstage/plugin-app-backend": "workspace:^",
    "@backstage/plugin-auth-node": "workspace:^",
    "@backstage/plugin-azure-devops-backend": "workspace:^",
    "@backstage/plugin-badges-backend": "workspace:^",
    "@backstage/plugin-catalog-backend": "workspace:^",
    "@backstage/plugin-catalog-backend-module-unprocessed": "workspace:^",
    "@backstage/plugin-devtools-backend": "workspace:^",
    "@backstage/plugin-entity-feedback-backend": "workspace:^",
    "@backstage/plugin-kubernetes-backend": "workspace:^",
    "@backstage/plugin-lighthouse-backend": "workspace:^",
    "@backstage/plugin-linguist-backend": "workspace:^",
    "@backstage/plugin-permission-backend": "workspace:^",
    "@backstage/plugin-permission-common": "workspace:^",
    "@backstage/plugin-permission-node": "workspace:^",
    "@backstage/plugin-scaffolder-backend": "workspace:^",
    "@backstage/plugin-search-backend": "workspace:^",
    "@backstage/plugin-search-backend-module-catalog": "workspace:^",
    "@backstage/plugin-search-backend-module-explore": "workspace:^",
    "@backstage/plugin-search-backend-module-techdocs": "workspace:^",
    "@backstage/plugin-search-backend-node": "workspace:^",
    "@backstage/plugin-techdocs-backend": "workspace:^"

"@backstage/plugin-todo-backend": "workspace:^"
},
"devDependencies": {
Expand Down
Loading