Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/shortcuts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"dependencies": {
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Pinning the @backstage/theme dependency to a specific version (0.1.1) breaks the monorepo's workspace linking. This package should reference the local @backstage/theme package using workspace:^ to ensure consistency and use the code from within this repository. The current version of @backstage/theme in the workspace is 0.4.1, so this change would also introduce an outdated version. The security vulnerability should be addressed within the @backstage/theme package at the root of the monorepo, not by pinning a version in a consuming package.

Suggested change
"@backstage/theme": "0.1.1",
"@backstage/theme": "workspace:^",

"@backstage/types": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading