Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/catalog-unprocessed-entities/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Pinning an internal dependency to a specific version (0.1.1) instead of using workspace:^ goes against this monorepo's dependency strategy. This is also a significant downgrade from the current workspace version (0.4.1) and can cause inconsistencies and runtime issues. The security vulnerability should be addressed at the repository level, for instance, by using Yarn's resolutions in the root package.json.

Suggested change
"@backstage/theme": "0.1.1",
"@backstage/theme": "workspace:^",

"@material-ui/core": "^4.9.13",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "^4.0.0-alpha.60",
Expand Down
Loading