Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/nomad/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/core-plugin-api": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change from "workspace:^" to a hardcoded version "0.1.0" is incorrect for this monorepo setup. The workspace: protocol is essential for linking packages within the same Yarn workspace, ensuring consistency and proper local development.

Pinning to a specific version, especially a very outdated one like 0.1.0 (the version in the workspace is 1.5.3), will break dependency resolution and likely cause build or runtime failures. This automated change should be reverted. The underlying security vulnerabilities should be addressed by updating dependencies correctly across the monorepo, which will also allow the yarn.lock file to be updated properly.

Suggested change
"@backstage/core-plugin-api": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",

"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.9.13",
Expand Down
Loading