Skip to content

[Snyk] Fix for 2 vulnerabilities#11813

Closed
q1blue wants to merge 2 commits intomasterfrom
snyk-fix-c1bb894602f7cb0dadd67c76c1ba6210
Closed

[Snyk] Fix for 2 vulnerabilities#11813
q1blue wants to merge 2 commits intomasterfrom
snyk-fix-c1bb894602f7cb0dadd67c76c1ba6210

Conversation

@q1blue
Copy link
Copy Markdown
Collaborator

@q1blue q1blue commented Feb 6, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/adr-backend/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
low severity Server-side Request Forgery (SSRF)
SNYK-JS-WEBPACK-15235959
  84  
low severity Server-side Request Forgery (SSRF)
SNYK-JS-WEBPACK-15235969
  84  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Server-side Request Forgery (SSRF)


EntelligenceAI PR Summary

This PR transitions the ADR backend plugin from workspace dependencies to fixed package versions for improved version control and standalone package preparation.

  • Changed @backstage/plugin-adr-common from workspace:^ to fixed version 0.1.0
  • Changed @backstage/plugin-search-common from workspace:^ to fixed version 0.3.1
  • Modified plugins/adr-backend/package.json dependency declarations
  • Enables standalone package distribution and explicit version management

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Feb 6, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, focuses on enhancing the security posture of the plugins/adr-backend module. It achieves this by updating two key Backstage plugin dependencies, @backstage/plugin-adr-common and @backstage/plugin-search-common, to newer versions that contain fixes for identified Server-side Request Forgery (SSRF) vulnerabilities.

Highlights

  • Dependency Updates: The @backstage/plugin-adr-common dependency has been updated to version 0.1.0, and @backstage/plugin-search-common to 0.3.1 within plugins/adr-backend/package.json.
  • Security Fixes: This PR addresses two Server-side Request Forgery (SSRF) vulnerabilities (SNYK-JS-WEBPACK-15235959 and SNYK-JS-WEBPACK-15235969), each with a severity score of 84, by upgrading the aforementioned dependencies.
Changelog
  • plugins/adr-backend/package.json
    • The dependency @backstage/plugin-adr-common was updated from workspace:^ to 0.1.0.
    • The dependency @backstage/plugin-search-common was updated from workspace:^ to 0.3.1.
Activity
  • This pull request was automatically created by Snyk to propose fixes for identified vulnerabilities.
  • A warning is present indicating that the yarn.lock file failed to update and requires manual intervention.
  • The PR description provides detailed information about the vulnerabilities fixed and guidance for users of Yarn's zero-install feature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Feb 6, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@entelligence-ai-pr-reviews
Copy link
Copy Markdown

Walkthrough

This PR updates the dependency management strategy for the ADR backend plugin by replacing workspace protocol references with fixed version numbers. Two Backstage plugin dependencies are affected: @backstage/plugin-adr-common is now pinned to version 0.1.0, and @backstage/plugin-search-common is pinned to version 0.3.1. This transition from monorepo workspace dependencies (workspace:^) to explicit published package versions indicates the plugin is being prepared for standalone distribution or requires more controlled version management. This change ensures reproducible builds and clearer dependency tracking when the package is consumed outside the monorepo context.

Changes

File(s) Summary
plugins/adr-backend/package.json Updated dependency version specifications from workspace protocol (workspace:^) to fixed versions: @backstage/plugin-adr-common pinned to 0.1.0 and @backstage/plugin-search-common pinned to 0.3.1.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant Build as Build System
    participant Registry as NPM Registry
    participant ADRBackend as ADR Backend Plugin

    Note over Dev,ADRBackend: Dependency Version Pinning Process

    Dev->>ADRBackend: Update package.json dependencies
    Note right of Dev: Change workspace:^ to fixed versions<br/>- adr-common: 0.1.0<br/>- search-common: 0.3.1

    Dev->>Build: Trigger build process
    
    Build->>Registry: Resolve @backstage/plugin-adr-common@0.1.0
    Registry-->>Build: Return package
    
    Build->>Registry: Resolve @backstage/plugin-search-common@0.3.1
    Registry-->>Build: Return package
    
    Build->>ADRBackend: Install pinned dependencies
    Note over Build,ADRBackend: Dependencies now reference<br/>published versions instead of<br/>workspace packages
    
    Build-->>Dev: Build complete with pinned versions
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, generated by Snyk, aims to address two vulnerabilities by updating dependency versions. However, the proposed changes involve downgrading @backstage/plugin-adr-common and @backstage/plugin-search-common to significantly older versions (0.1.0 and 0.3.1 respectively) from their current workspace:^ declarations. This contradicts the project's apparent dependency management strategy and the versions listed in the CHANGELOG.md for this package, which indicate much newer versions (0.2.11 and 1.2.5). Downgrading dependencies can introduce regressions, compatibility issues, or fail to incorporate recent bug fixes and features. It is crucial to ensure that the proposed versions are indeed the correct and most secure ones, and that they do not negatively impact the stability or functionality of the plugin. The yarn.lock also failed to update, indicating potential issues with the automated fix.

Comment on lines +38 to +39
"@backstage/plugin-adr-common": "0.1.0",
"@backstage/plugin-search-common": "0.3.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The dependencies @backstage/plugin-adr-common and @backstage/plugin-search-common are being changed from workspace:^ to fixed, older versions (0.1.0 and 0.3.1). This is a significant downgrade from the versions (0.2.11 and 1.2.5 respectively) that are currently available in the monorepo and referenced in the CHANGELOG.md for this package. Downgrading dependencies can lead to unexpected behavior, compatibility issues, or reintroduce bugs. It also deviates from the workspace:^ strategy, which is generally preferred for monorepos to ensure consistency and leverage the latest compatible versions. Please confirm if these specific older versions are truly necessary for the vulnerability fix, or if workspace:^ should be maintained to use the latest patched versions available in the workspace.

"@backstage/plugin-adr-common": "workspace:^","@backstage/plugin-search-common": "workspace:^"

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Feb 14, 2026
@github-actions github-actions Bot closed this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants