Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/adr-backend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-adr-common": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-adr-common": "0.1.0",
"@backstage/plugin-search-common": "0.3.1",
Comment on lines +38 to +39
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The dependencies @backstage/plugin-adr-common and @backstage/plugin-search-common are being changed from workspace:^ to fixed, older versions (0.1.0 and 0.3.1). This is a significant downgrade from the versions (0.2.11 and 1.2.5 respectively) that are currently available in the monorepo and referenced in the CHANGELOG.md for this package. Downgrading dependencies can lead to unexpected behavior, compatibility issues, or reintroduce bugs. It also deviates from the workspace:^ strategy, which is generally preferred for monorepos to ensure consistency and leverage the latest compatible versions. Please confirm if these specific older versions are truly necessary for the vulnerability fix, or if workspace:^ should be maintained to use the latest patched versions available in the workspace.

"@backstage/plugin-adr-common": "workspace:^","@backstage/plugin-search-common": "workspace:^"

"@types/express": "^4.17.6",
"express": "^4.17.1",
"express-promise-router": "^4.1.0",
Expand Down
Loading