Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/airbrake-backend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change introduces a critical issue by pinning @backstage/config to version 0.1.1, while other packages in this monorepo use workspace:^ to resolve to the workspace version, which is 1.0.8.

This downgrade will cause two different versions of @backstage/config to be installed, leading to type incompatibilities that will likely break the build or cause runtime errors. For example, the airbrakePlugin receives a config object from coreServices (which uses @backstage/config@1.0.8) and passes it to extractAirbrakeConfig, which expects a Config type from @backstage/config@0.1.1.

To maintain consistency and prevent these issues, this dependency should continue to use the version from the workspace.

Suggested change
"@backstage/config": "0.1.1",
"@backstage/config": "workspace:^",

"@types/express": "*",
"express": "^4.17.1",
"express-promise-router": "^4.1.0",
Expand Down
Loading