Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/scaffolder-backend-module-sentry/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-scaffolder-node": "workspace:^"
"@backstage/config": "0.1.1",
"@backstage/errors": "0.1.1",
"@backstage/plugin-scaffolder-node": "0.2.0"
Comment on lines +25 to +27
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly downgrades several dependencies. The workspace:^ protocol is used in this monorepo to refer to other packages within the same repository. By replacing it with pinned, old versions, you are introducing significant downgrades:

  • @backstage/config is downgraded from a workspace version (which is 1.0.8 in this repository) to 0.1.1.
  • @backstage/errors is downgraded from a workspace version (which is 1.2.1 in this repository) to 0.1.1.

This will almost certainly break the application. These changes should be reverted. The Snyk bot seems to have misinterpreted the workspace: protocol. The underlying vulnerability should be addressed without downgrading these packages. Furthermore, the PR description warns that yarn.lock failed to update, which is another strong indicator that these changes are problematic.

Suggested change
"@backstage/config": "0.1.1",
"@backstage/errors": "0.1.1",
"@backstage/plugin-scaffolder-node": "0.2.0"
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-scaffolder-node": "workspace:^"

},
"devDependencies": {
"@backstage/cli": "workspace:^"
Expand Down
Loading