Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/catalog-backend-module-gitlab/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,14 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-node": "1.0.0",
Comment on lines +48 to +55
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated change introduces significant risks and is likely to break the application. It replaces workspace:^ specifiers with pinned versions, which is incorrect in a monorepo context. More importantly, it downgrades several packages to older major versions:

  • @backstage/catalog-model is downgraded from a workspace version (likely ^1.4.1) to 0.1.1.
  • @backstage/plugin-catalog-node is downgraded from a workspace version (likely ^1.4.1-next.0) to 1.0.0.

These downgrades are severe breaking changes. The warning in the PR description about yarn.lock failing to update is another strong indicator that this change is incorrect. The correct way to fix the underlying security issue is to update the vulnerable transitive dependency within the monorepo, not by pinning and downgrading direct dependencies. These changes should be reverted.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/backend-tasks": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/integration": "workspace:^",
    "@backstage/plugin-catalog-node": "workspace:^"

"@backstage/types": "workspace:^",
"lodash": "^4.17.21",
"node-fetch": "^2.6.7",
Expand Down
Loading