Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/search-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
},
"dependencies": {
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/types": "workspace:^"
"@backstage/types": "0.1.1"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change from workspace:^ to a pinned version 0.1.1 is incorrect for a monorepo using Yarn workspaces.

  • Breaks workspace linking: It replaces a workspace-protocol dependency with a pinned version, which will likely introduce duplicate dependencies.
  • Version downgrade: The version of @backstage/types in the workspace is 1.1.0, so changing to 0.1.1 is a downgrade.
  • Dependency conflicts: This package also depends on @backstage/plugin-permission-common, which in turn depends on @backstage/types at workspace:^. This change would result in two different versions of @backstage/types being used, which can cause subtle runtime issues and type incompatibilities.

The stated goal is to fix a webpack vulnerability, but this change to @backstage/types does not seem to address the root cause.

I recommend reverting this change and instead investigating the correct way to upgrade the vulnerable dependency.

Suggested change
"@backstage/types": "0.1.1"
"@backstage/types": "workspace:^"

},
"devDependencies": {
"@backstage/cli": "workspace:^"
Expand Down
Loading