Skip to content
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/analytics-module-ga/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly pins the @backstage/theme dependency to version 0.1.1. This is a significant downgrade from the version in the workspace (0.4.1) and breaks the monorepo's dependency strategy of using workspace:^. This can lead to build failures, runtime errors, and the re-introduction of bugs. It's recommended to revert this change and address the vulnerability by updating dependencies correctly within the monorepo.

    "@backstage/theme": "workspace:^"

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading