Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/search-backend-module-techdocs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,17 +36,17 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-search-backend-node": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-techdocs-node": "workspace:^",
"@backstage/plugin-search-common": "0.3.1",
"@backstage/plugin-techdocs-node": "1.13.11",
Comment on lines +39 to +49
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated dependency update has several critical issues and should be reverted.

  1. Major dependency downgrades: This change downgrades several @backstage packages to much older major versions, which will almost certainly introduce breaking changes and regressions. For example:

    • @backstage/plugin-catalog-common is downgraded from a version compatible with 1.0.15 to 0.1.0.
    • @backstage/plugin-search-common is downgraded from a version compatible with 1.2.5 to 0.3.1.

    These downgrades suggest that the Snyk tool may have had trouble resolving the correct dependency versions within the yarn workspace (workspace:^).

  2. yarn.lock not updated: The PR description states that yarn.lock was not updated. This is a critical problem as it means the dependency tree is not locked, and builds will not be reproducible. The vulnerabilities might not even be fixed without the lock file update.

It is strongly recommended to address the vulnerabilities manually by finding appropriate versions that do not introduce breaking changes, likely by updating the packages within the monorepo to newer, non-vulnerable versions and continuing to use workspace:^.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/backend-tasks": "workspace:^",
    "@backstage/catalog-client": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/plugin-catalog-common": "workspace:^",
    "@backstage/plugin-permission-common": "workspace:^",
    "@backstage/plugin-search-backend-node": "workspace:^",
    "@backstage/plugin-search-common": "workspace:^",
    "@backstage/plugin-techdocs-node": "workspace:^"

"lodash": "^4.17.21",
"node-fetch": "^2.6.7",
"p-limit": "^3.1.0",
Expand Down
Loading