Skip to content

[Snyk] Fix for 3 vulnerabilities #11905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 3 vulnerabilities #11905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/tech-insights-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-tasks": "0.6.1",
"@backstage/config": "workspace:^",
"@backstage/plugin-tech-insights-common": "workspace:^",
"@backstage/plugin-tech-insights-common": "0.1.0",
Comment on lines +35 to +38
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes are highly problematic and should not be merged.

  • Incorrect Dependency Pinning: The change from workspace:^ to pinned versions is an anti-pattern in a monorepo. It breaks the linkage between local packages, which can lead to version conflicts and makes local development and testing difficult.

  • Major Dependency Downgrade: The @backstage/plugin-tech-insights-common package is being downgraded from 0.2.11 (the current version in the workspace) to 0.1.0. This is a significant downgrade that will likely cause breaking changes, as APIs have likely changed substantially between these versions.

  • Incomplete Changes: The PR description explicitly warns that yarn.lock has not been updated. Merging this would leave package.json and yarn.lock out of sync, breaking the build for anyone who pulls these changes.

The recommended approach is to investigate the vulnerabilities and update the affected packages within the monorepo itself, rather than pinning them in this package. This will maintain the integrity of the workspace and resolve the security issues correctly.

"@backstage/types": "workspace:^",
"@types/luxon": "^3.0.0",
"luxon": "^3.0.0",
Expand Down
Loading