[Snyk] Security upgrade @backstage/plugin-permission-common from 0.0.0-use.local to 0.1.0#11914
[Snyk] Security upgrade @backstage/plugin-permission-common from 0.0.0-use.local to 0.1.0#11914
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-WEBPACK-15235959 - https://snyk.io/vuln/SNYK-JS-WEBPACK-15235969 - https://snyk.io/vuln/SNYK-JS-QS-15268416
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates a critical security update to resolve multiple vulnerabilities within the project's dependencies. By upgrading a key Backstage plugin, it enhances the overall security posture and mitigates potential risks associated with outdated packages, ensuring a more robust and secure application environment. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
WalkthroughThis pull request modifies the dependency management for the Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant PM as Package Manager
participant Jenkins as jenkins-common plugin
participant PermCommon as plugin-permission-common
Note over Dev,PermCommon: Dependency Resolution Change
Dev->>PM: npm install / yarn install
alt Before: workspace:^ version
PM->>Jenkins: Resolve dependencies
Jenkins->>PM: Request plugin-permission-common (workspace)
PM->>PermCommon: Link local workspace version
PermCommon-->>Jenkins: Local monorepo version
else After: 0.1.0 version
PM->>Jenkins: Resolve dependencies
Jenkins->>PM: Request plugin-permission-common@0.1.0
PM->>PermCommon: Fetch from npm registry
PermCommon-->>Jenkins: Published version 0.1.0
end
PM-->>Dev: Dependencies installed
Note over Jenkins,PermCommon: No code logic changes<br/>Only dependency source changed
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, aims to address security vulnerabilities by modifying the @backstage/plugin-permission-common dependency. However, the proposed change is incorrect as it downgrades the package from the current workspace version (0.7.7) to a much older, hardcoded version (0.1.0). This breaks the monorepo's dependency strategy of using workspace:^ to ensure all internal packages are consistent. This change will likely lead to build failures or runtime errors and should be rejected. The dependency should continue to reference the workspace version.
| "dependencies": { | ||
| "@backstage/plugin-catalog-common": "workspace:^", | ||
| "@backstage/plugin-permission-common": "workspace:^" | ||
| "@backstage/plugin-permission-common": "0.1.0" |
There was a problem hiding this comment.
This change incorrectly downgrades @backstage/plugin-permission-common from the workspace version (which is 0.7.7) to a hardcoded, much older version (0.1.0). In a monorepo using Yarn workspaces, dependencies between packages should use workspace:^ to ensure consistency and use the code from within the repository. Pinning to an old, external version will likely cause build failures or runtime issues and defeats the purpose of a monorepo. This change should be reverted.
| "@backstage/plugin-permission-common": "0.1.0" | |
| "@backstage/plugin-permission-common": "workspace:^" |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
2 participants
Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/jenkins-common/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-WEBPACK-15235959
SNYK-JS-WEBPACK-15235969
SNYK-JS-QS-15268416
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling
🦉 Server-side Request Forgery (SSRF)
EntelligenceAI PR Summary
This PR updates the dependency version specifier for
@backstage/plugin-permission-commonin the jenkins-common plugin package configuration.workspace:^) with fixed version0.1.0