Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
},
"version": "1.17.0-next.0",
"dependencies": {
"@backstage/errors": "workspace:^",
"@backstage/errors": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly downgrades @backstage/errors. The version is being changed from workspace:^ (which resolves to the local 1.2.1 in this monorepo) to the much older 0.1.1. This will likely cause breakages.

This also breaks the yarn workspace convention by fetching an old version from the registry instead of using the local package. This PR seems to be based on a faulty analysis by Snyk and should be rejected. Please revert this change.

Suggested change
"@backstage/errors": "0.1.1",
"@backstage/errors": "workspace:^",

"@manypkg/get-packages": "^1.1.3"
},
"devDependencies": {
Expand Down
Loading