Skip to content

[Snyk] Fix for 3 vulnerabilities #11941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 3 vulnerabilities #11941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/firehydrant/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/theme": "0.1.1",
Comment on lines +29 to +30
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes are incorrect and will almost certainly break the application. Pinning @backstage/plugin-catalog-react to 0.0.1 and @backstage/theme to 0.1.1 represents a major version downgrade. The project's CHANGELOG.md indicates that much newer versions of these packages are in use (e.g., @backstage/plugin-catalog-react@1.8.1-next.0 and @backstage/theme@0.4.1).

Introducing these very old versions will create significant API incompatibilities with other @backstage dependencies that are correctly using the workspace:^ protocol and are on much more recent versions. This will likely lead to build failures or runtime errors.

This change should be reverted. To properly address the security vulnerabilities, consider one of the following approaches:

  1. Update the root dependencies in the monorepo that are introducing the vulnerable transitive dependencies.
  2. Use yarn resolutions in the root package.json to force non-vulnerable versions of the transitive dependencies (e.g., qs, webpack).
Suggested change
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/theme": "0.1.1",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading