Skip to content

[Snyk] Fix for 3 vulnerabilities#11945

Closed
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-f9dd4fee3f3f6bfd15b3132231b93dd4
Closed

[Snyk] Fix for 3 vulnerabilities#11945
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-f9dd4fee3f3f6bfd15b3132231b93dd4

Conversation

@q1blue
Copy link
Copy Markdown
Collaborator

@q1blue q1blue commented Feb 12, 2026

snyk-top-banner

Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • packages/catalog-model/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
low severity Server-side Request Forgery (SSRF)
SNYK-JS-WEBPACK-15235959
  83  
low severity Server-side Request Forgery (SSRF)
SNYK-JS-WEBPACK-15235969
  83  
medium severity Allocation of Resources Without Limits or Throttling
SNYK-JS-QS-15268416
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Allocation of Resources Without Limits or Throttling
🦉 Server-side Request Forgery (SSRF)


EntelligenceAI PR Summary

Pinned internal Backstage dependencies to explicit versions in the catalog-model package.

  • Changed @backstage/config from workspace:^ to 0.1.1
  • Changed @backstage/types from workspace:^ to 0.1.1
  • Transitions from workspace protocol to fixed version pinning for consistent dependency resolution

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Feb 12, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@entelligence-ai-pr-reviews
Copy link
Copy Markdown

Walkthrough

This pull request updates the dependency management strategy for the catalog-model package by transitioning from workspace protocol references to explicit version pinning. Specifically, two internal Backstage dependencies (@backstage/config and @backstage/types) are changed from flexible workspace references (workspace:^) to fixed version 0.1.1. This change likely supports package publishing workflows or ensures consistent dependency resolution across different environments by removing reliance on workspace-based dependency management.

Changes

File(s) Summary
packages/catalog-model/package.json Updated @backstage/config and @backstage/types dependencies from workspace:^ to pinned version 0.1.1.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager
    participant WS as Workspace Registry
    participant NPM as NPM Registry
    participant CM as catalog-model

    Dev->>PM: Update package.json dependencies
    Note over Dev,PM: Pin @backstage/config to 0.1.1<br/>Pin @backstage/types to 0.1.1

    PM->>CM: Read package.json
    CM-->>PM: Dependencies list

    alt @backstage/config resolution
        PM->>NPM: Resolve @backstage/config@0.1.1
        NPM-->>PM: Package version 0.1.1
        Note over PM,NPM: Previously resolved from workspace
    end

    alt @backstage/types resolution
        PM->>NPM: Resolve @backstage/types@0.1.1
        NPM-->>PM: Package version 0.1.1
        Note over PM,NPM: Previously resolved from workspace
    end

    PM->>CM: Install pinned dependencies
    CM-->>PM: Installation complete

    PM-->>Dev: Dependencies updated successfully
    Note over Dev,CM: catalog-model now uses<br/>fixed versions instead of<br/>workspace references
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to enhance the project's security posture by resolving three critical vulnerabilities detected by Snyk. It achieves this by updating specific internal Backstage dependencies to newer, more secure versions within the catalog-model package. The changes ensure that the project benefits from the latest security patches, although a manual yarn.lock update is necessary to fully integrate these dependency changes.

Highlights

  • Security Vulnerability Fixes: Addressed 3 identified vulnerabilities: two Server-side Request Forgery (SSRF) issues (SNYK-JS-WEBPACK-15235959, SNYK-JS-WEBPACK-15235969) and one Allocation of Resources Without Limits or Throttling issue (SNYK-JS-QS-15268416).
  • Dependency Updates: Updated @backstage/config and @backstage/types dependencies in packages/catalog-model/package.json from workspace:^ to explicit version 0.1.1 to resolve vulnerabilities.
  • Manual yarn.lock Update Required: The yarn.lock file was not automatically updated by Snyk and requires a manual update before merging to ensure correct dependency resolution, especially for zero-installs users.
Changelog
  • packages/catalog-model/package.json
    • Updated @backstage/config dependency from workspace:^ to 0.1.1.
    • Updated @backstage/types dependency from workspace:^ to 0.1.1.
Activity
  • This pull request was automatically generated by Snyk to address identified security vulnerabilities.
  • Snyk reported a failure to update the yarn.lock file, indicating it requires manual intervention.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, attempts to fix vulnerabilities by pinning @backstage/config and @backstage/types to version 0.1.1. However, this is a significant and incorrect downgrade from the versions that would be resolved from the workspace (1.0.8 and 1.1.0 respectively). This change is likely to break the build and introduce regressions. I have left a critical comment recommending to revert these changes and investigate the vulnerabilities manually for a proper fix. Additionally, the PR notes that yarn.lock was not updated, which would need to be done manually after any dependency changes.

Comment on lines +47 to +49
"@backstage/config": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/types": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change downgrades @backstage/config and @backstage/types to very old versions (0.1.1). The workspace:^ protocol ensures that you use the version of these packages from the current monorepo, which are @backstage/config@1.0.8 and @backstage/types@1.1.0.

Pinning to such old versions is a significant downgrade and will likely cause build failures or runtime issues. It seems the automated tool has made an error. Instead of pinning to these old versions, you should investigate the vulnerabilities and find a more appropriate fix, which might involve updating transitive dependencies or finding a different resolution that doesn't involve such a drastic downgrade of direct dependencies.

I recommend reverting this change and investigating the Snyk vulnerabilities manually.

    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/types": "workspace:^"

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Feb 12, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Feb 19, 2026
@github-actions github-actions Bot closed this Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants