Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions plugins/auth-backend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/catalog-client": "0.2.0",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-auth-node": "0.6.0",
Comment on lines +35 to +40
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change replaces workspace:^ with pinned versions for several @backstage packages, introducing major downgrades for some (e.g., @backstage/catalog-client from 1.4.3 to 0.2.0). This will almost certainly break the application. In a monorepo setup like Backstage, workspace:^ is crucial for ensuring local packages are used correctly. Pinning to arbitrary versions from the registry is incorrect and dangerous. Please revert these changes. To fix the underlying vulnerabilities, consider updating the transitive dependencies within the source packages or using resolutions in the root package.json.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/catalog-client": "0.2.0",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-auth-node": "0.6.0",
"@backstage/backend-common": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",

"@backstage/types": "workspace:^",
"@davidzemon/passport-okta-oauth": "^0.0.5",
"@google-cloud/firestore": "^6.0.0",
Expand All @@ -47,7 +47,7 @@
"connect-session-knex": "^3.0.1",
"cookie-parser": "^1.4.5",
"cors": "^2.8.5",
"express": "^4.17.1",
"express": "^4.22.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The specified version ^4.22.0 for the express package does not exist in the npm registry. The latest version is 4.19.2. This will cause dependency installation to fail, which is likely why the yarn.lock file failed to update. Please use a valid version.

Suggested change
"express": "^4.22.0",
"express": "^4.19.2",

"express-promise-router": "^4.1.0",
"express-session": "^1.17.1",
"fs-extra": "10.1.0",
Expand All @@ -63,7 +63,7 @@
"node-fetch": "^2.6.7",
"openid-client": "^5.2.1",
"passport": "^0.6.0",
"passport-auth0": "^1.4.3",
"passport-auth0": "^1.4.4",
"passport-bitbucket-oauth2": "^0.1.2",
"passport-github2": "^0.1.12",
"passport-gitlab2": "^5.0.0",
Expand Down
Loading