Skip to content

[Snyk] Fix for 2 vulnerabilities #11961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #11961

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/kubernetes-common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@kubernetes/client-node": "0.18.1"
"@backstage/plugin-permission-common": "0.1.0",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Changing @backstage/plugin-permission-common from workspace:^ to a pinned version 0.1.0 is incorrect in this monorepo setup. It breaks the workspace linking and attempts to use a significantly older version of the package (the workspace version is 0.7.7). This will likely cause build failures or runtime errors. This change should be reverted to use the workspace version.

Suggested change
"@backstage/plugin-permission-common": "0.1.0",
"@backstage/plugin-permission-common": "workspace:^",

"@kubernetes/client-node": "1.0.0"
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While upgrading @kubernetes/client-node is necessary to fix the vulnerability, this change is incomplete. Other packages in this monorepo, such as plugins/kubernetes-backend and plugins/kubernetes, also depend on @kubernetes/client-node@0.18.1. Updating this dependency in isolation here to 1.0.0 (a major version bump) will introduce multiple, incompatible versions of the same package, likely leading to type conflicts and runtime errors. The upgrade should be applied consistently across all relevant package.json files in the repository.

},
"devDependencies": {
"@backstage/cli": "workspace:^"
Expand Down
Loading