Skip to content

[Snyk] Fix for 3 vulnerabilities #11962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 3 vulnerabilities #11962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/octopus-deploy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/theme": "0.1.1",
Comment on lines +28 to +29
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Pinning @backstage/plugin-catalog-react and @backstage/theme to old, fixed versions instead of using workspace:^ is incorrect for this monorepo structure. This change will likely break the build or cause runtime issues.

For instance, @backstage/theme exists in this monorepo at version 0.4.1 (as per packages/theme/package.json), but this change downgrades it to 0.1.1.

This automated change doesn't correctly handle yarn workspaces. The underlying vulnerabilities should be addressed by updating the dependencies within the workspace packages themselves, rather than pinning to outdated public versions. The warning in the PR description about yarn.lock failing to update is a strong indicator that this approach is flawed.

    "@backstage/plugin-catalog-react": "workspace:^",
    "@backstage/theme": "workspace:^"

"@material-ui/core": "^4.9.13",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading