Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/graphiql/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Pinning this dependency to a specific version breaks the Yarn workspace linkage. This package should use the local workspace version via "workspace:^" to ensure consistency and receive updates from within the monorepo. Pinning to an old version (0.1.0) is a significant downgrade from the workspace version (0.13.4-next.0) and will likely cause breakages. The correct approach is to address the underlying vulnerability within the @backstage/core-components package itself, rather than pinning an outdated version here.

Suggested change
"@backstage/core-components": "0.1.0",
"@backstage/core-components": "workspace:^",

"@backstage/core-plugin-api": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Similar to @backstage/core-components, this dependency should not be pinned to a specific version. It breaks the Yarn workspace setup by ignoring the local @backstage/theme package. This change also represents a significant downgrade from the workspace version 0.4.1 to 0.1.1. Please revert this to use "workspace:^" to maintain monorepo integrity.

Suggested change
"@backstage/theme": "0.1.1",
"@backstage/theme": "workspace:^",

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading