-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 3 vulnerabilities #11963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -32,9 +32,9 @@ | |||||
| "clean": "backstage-cli package clean" | ||||||
| }, | ||||||
| "dependencies": { | ||||||
| "@backstage/core-components": "workspace:^", | ||||||
| "@backstage/core-components": "0.1.0", | ||||||
| "@backstage/core-plugin-api": "workspace:^", | ||||||
| "@backstage/theme": "workspace:^", | ||||||
| "@backstage/theme": "0.1.1", | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar to
Suggested change
|
||||||
| "@material-ui/core": "^4.12.2", | ||||||
| "@material-ui/icons": "^4.9.1", | ||||||
| "@material-ui/lab": "4.0.0-alpha.61", | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinning this dependency to a specific version breaks the Yarn workspace linkage. This package should use the local workspace version via
"workspace:^"to ensure consistency and receive updates from within the monorepo. Pinning to an old version (0.1.0) is a significant downgrade from the workspace version (0.13.4-next.0) and will likely cause breakages. The correct approach is to address the underlying vulnerability within the@backstage/core-componentspackage itself, rather than pinning an outdated version here.