Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/tech-insights-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/types": "workspace:^",
"@backstage/types": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated change is incorrect and should be rejected. It replaces the yarn workspace dependency with a pinned, and much older, version of @backstage/types.

  1. Breaks Workspace Linking: Changing "workspace:^" to "0.1.1" will cause yarn to fetch this package from the npm registry instead of linking to the local @backstage/types package within this monorepo. This is a fundamental change to how dependencies are managed in this project.

  2. Significant Downgrade: The suggested version 0.1.1 is a major downgrade. The local @backstage/types package is at version 1.1.0. This downgrade would likely cause build failures or runtime errors, as tech-insights-common depends on features from newer versions of @backstage/types.

It appears Snyk has misinterpreted the workspace:^ protocol, which is also indicated by the warning in the PR description about failing to update yarn.lock. The vulnerabilities it aims to fix may already be resolved in the 1.1.0 version currently in use via the workspace. This PR should be closed. If vulnerabilities persist, the dependencies of the @backstage/types package should be updated directly.

Suggested change
"@backstage/types": "0.1.1",
"@backstage/types": "workspace:^",

"@types/luxon": "^3.0.0",
"luxon": "^3.0.0"
},
Expand Down
Loading