Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/kafka-backend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
Comment on lines +38 to +40
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependencies were changed from workspace:^ to pinned versions. This is incorrect for a monorepo using Yarn workspaces and will likely cause issues.

  • @backstage/catalog-model is being downgraded from version 1.4.1 (the version in your workspace) to 0.1.1. This is a significant downgrade and will almost certainly break your application.
  • @backstage/backend-common is being upgraded, but pinning it breaks the workspace link, which can lead to inconsistent dependency resolution across your project.

The workspace:^ protocol ensures that you are using the version of the package from within your monorepo. Automated tools like Snyk sometimes fail to handle this correctly.

It's recommended to revert these changes and keep using workspace:^. If there are vulnerabilities in these packages, they should be addressed by updating the packages themselves within the monorepo or updating their transitive dependencies.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/catalog-model": "workspace:^"

"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@types/express": "^4.17.6",
"express": "^4.17.1",
"express": "^4.22.0",
"express-promise-router": "^4.1.0",
"kafkajs": "^2.0.0",
"lodash": "^4.17.21",
Expand Down
Loading