forked from SDA-SE/backstage
-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 3 vulnerabilities #11967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These dependencies were changed from
workspace:^to pinned versions. This is incorrect for a monorepo using Yarn workspaces and will likely cause issues.@backstage/catalog-modelis being downgraded from version1.4.1(the version in your workspace) to0.1.1. This is a significant downgrade and will almost certainly break your application.@backstage/backend-commonis being upgraded, but pinning it breaks the workspace link, which can lead to inconsistent dependency resolution across your project.The
workspace:^protocol ensures that you are using the version of the package from within your monorepo. Automated tools like Snyk sometimes fail to handle this correctly.It's recommended to revert these changes and keep using
workspace:^. If there are vulnerabilities in these packages, they should be addressed by updating the packages themselves within the monorepo or updating their transitive dependencies.