Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions plugins/tech-insights-backend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,18 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-tasks": "0.6.1",
"@backstage/catalog-client": "0.2.0",
"@backstage/catalog-model": "0.1.1",
Comment on lines +36 to +39
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes from workspace:^ to pinned versions for @backstage packages are likely incorrect for a monorepo setup. Using workspace:^ ensures that packages within this monorepo use the local workspace versions, which is crucial for development and consistency. Pinning them to specific versions breaks this linkage and can lead to issues. It seems like an automated tool might have made this change without understanding the context of yarn workspaces. It's recommended to revert these specific changes and keep workspace:^.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/backend-tasks": "0.6.1",
"@backstage/catalog-client": "0.2.0",
"@backstage/catalog-model": "0.1.1",
"@backstage/backend-common": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",

"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-tech-insights-common": "workspace:^",
"@backstage/plugin-tech-insights-node": "workspace:^",
"@backstage/types": "workspace:^",
"@types/express": "^4.17.6",
"@types/luxon": "^3.0.0",
"express": "^4.17.1",
"express": "^4.22.0",
"express-promise-router": "^4.1.0",
"knex": "^2.0.0",
"lodash": "^4.17.21",
Expand Down
Loading