Skip to content

[Snyk] Fix for 3 vulnerabilities #12003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 3 vulnerabilities #12003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/explore-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/config": "workspace:^",
"@backstage/plugin-explore-common": "workspace:^",
"@backstage/plugin-search-backend-module-explore": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-backend-module-explore": "0.3.6",
"@backstage/plugin-search-common": "0.3.1",
"@backstage/types": "workspace:^",
"@types/express": "*",
"express": "^4.18.1",
"express": "^4.22.0",
Comment on lines +25 to +32
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated dependency update has introduced several potentially critical issues:

  1. Change in Dependency Strategy: The change from workspace:^ to fixed versions for @backstage packages (e.g., @backstage/backend-common, @backstage/plugin-search-backend-module-explore, @backstage/plugin-search-common) alters how dependencies are resolved in this monorepo. Instead of using the local packages from the workspace, they will be fetched from the npm registry. This is a significant change and may not be the intended way to resolve vulnerabilities in a monorepo setup. It's often preferable to update the source of the workspace packages themselves.

  2. Major Version Downgrade: The dependency @backstage/plugin-search-common is being changed to version 0.3.1. Based on the provided plugins/search-common/package.json, the workspace version is 1.2.5. This is a major downgrade and is very likely to introduce breaking changes or compilation errors.

  3. Missing yarn.lock update: As noted in the pull request description, yarn.lock has not been updated. This is a critical omission. The lock file must be updated to ensure that the dependency changes are applied correctly and consistently.

Given these issues, this PR should be carefully reviewed and likely modified before merging. It's recommended to investigate the vulnerabilities and apply fixes by updating the workspace packages, and then regenerate the yarn.lock file.

"express-promise-router": "^4.1.0",
"lodash": "^4.17.21",
"node-fetch": "^2.6.7",
Expand Down
Loading