Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/user-settings/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/core-app-api": "workspace:^",
"@backstage/core-app-api": "0.1.0",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/theme": "0.1.1",
Comment on lines +35 to +40
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes incorrectly replace workspace:^ with old, pinned versions of @backstage packages. This is a significant downgrade and will likely break the application.

For example:

  • @backstage/core-app-api is being downgraded from workspace version 1.9.1-next.0 to 0.1.0.
  • @backstage/plugin-catalog-react is being downgraded from workspace version 1.8.1-next.0 to 0.0.1.
  • @backstage/theme is being downgraded from workspace version 0.4.1 to 0.1.1.

Using workspace:^ is the correct approach in this monorepo setup. These changes introduce major regressions and should be reverted. The vulnerabilities should be addressed by updating the underlying problematic packages, for example by using resolutions in the root package.json, not by downgrading these essential packages.

    "@backstage/core-app-api": "workspace:^",
    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^",
    "@backstage/theme": "workspace:^"

"@backstage/types": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading