Skip to content

[Snyk] Fix for 3 vulnerabilities #12019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 3 vulnerabilities #12019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/scaffolder-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/plugin-scaffolder-common": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/catalog-model": "0.1.1",
"@backstage/plugin-scaffolder-common": "0.1.0",
"@backstage/types": "0.1.1",
Comment on lines +27 to +30
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes are incorrect and will likely break the project. This PR replaces workspace-linked packages (workspace:^) with fixed, and mostly outdated, versions. For example, @backstage/catalog-model is downgraded from a workspace version equivalent to 1.4.1 to 0.1.1.

This change breaks the monorepo structure and can lead to:

  • Incompatibilities and runtime errors due to version mismatches.
  • Including multiple versions of the same package in the build.
  • Losing the benefits of workspace-based development.

The correct way to fix transitive dependency vulnerabilities in a yarn workspace is to use the resolutions field in the root package.json to pin the vulnerable package to a safe version. The fact that Snyk failed to update the yarn.lock file is a strong indicator that these changes create an unsatisfiable dependency tree.

I recommend reverting these changes and addressing the Snyk vulnerabilities using resolutions.

    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/plugin-scaffolder-common": "workspace:^",
    "@backstage/types": "workspace:^"

"jsonschema": "^1.2.6",
"winston": "^3.2.1",
"zod": "^3.21.4",
Expand Down
Loading