Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/scaffolder-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/types": "workspace:^"
"@backstage/types": "0.1.1"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly replaces the workspace:^ protocol with a pinned version. In this monorepo, workspace:^ is used to ensure that local packages from the workspace are used. By changing this to a specific version, you are forcing yarn to fetch this package from the remote registry instead of using the local one.

Furthermore, this is a significant downgrade. The version of @backstage/types in this workspace is 1.1.0, but this change pins it to 0.1.1. This will likely lead to build failures or runtime errors due to dependency mismatches.

The correct approach is to keep workspace:^ to refer to the package within this monorepo.

Suggested change
"@backstage/types": "0.1.1"
"@backstage/types": "workspace:^"

},
"devDependencies": {
"@backstage/cli": "workspace:^"
Expand Down
Loading