Skip to content

[Snyk] Fix for 3 vulnerabilities #12029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 3 vulnerabilities #12029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/gcalendar/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Comment on lines +25 to +28
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Pinning dependencies to old, fixed versions instead of using workspace:^ breaks the monorepo structure. This change will cause the gcalendar plugin to use outdated versions of @backstage/core-components (0.1.0 instead of the workspace version 0.13.4-next.0) and @backstage/theme (0.1.1 instead of 0.4.1), which will likely lead to build failures or runtime errors.

The correct approach to fix the security vulnerabilities is to update the transitive dependencies in their source packages within this repository. For instance, the qs vulnerability should be fixed by upgrading the qs version in packages/core-components/package.json.

Furthermore, the PR description notes that yarn.lock failed to update, which is another indication that these changes are not correct. It is highly recommended to close this PR and address the vulnerabilities at their source to maintain repository consistency and avoid breaking changes.

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading