Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/entity-validation/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/theme": "0.1.1",
Comment on lines +36 to +37
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes, intended to fix vulnerabilities, are incorrect and will likely break the project. They replace workspace:^ dependencies with very old, pinned versions of @backstage/plugin-catalog-react and @backstage/theme, breaking the monorepo workspace linking.

  • @backstage/plugin-catalog-react is being downgraded from a workspace version (the current version in the workspace is 1.8.1-next.0) to 0.0.1.
  • @backstage/theme is being downgraded from a workspace version (the current version in the workspace is 0.4.1) to 0.1.1.

These changes should be reverted. The vulnerabilities need to be addressed in a way that is compatible with the project's monorepo structure, for example by updating the packages within the workspace.

Suggested change
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/theme": "0.1.1",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",

"@codemirror/language": "^6.0.0",
"@codemirror/legacy-modes": "^6.1.0",
"@codemirror/view": "^6.0.0",
Expand Down
Loading