Skip to content

[Snyk] Fix for 3 vulnerabilities #12044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 3 vulnerabilities #12044

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/techdocs-cli-embedded-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@
"@backstage/cli": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/core-app-api": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/integration-react": "workspace:^",
"@backstage/integration-react": "0.1.1",
"@backstage/plugin-catalog": "workspace:^",
"@backstage/plugin-techdocs": "workspace:^",
"@backstage/plugin-techdocs": "0.1.1",
Comment on lines +15 to +19
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes from workspace:^ to specific versions are incorrect for this monorepo setup and should be reverted. They appear to be significant downgrades of these packages, not upgrades to fix vulnerabilities. For example:

  • @backstage/core-components is at version 0.13.4-next.0 in the workspace, but this change pins it to the much older version 0.1.0.
  • @backstage/integration-react is at version 1.1.16-next.0 in the workspace, but is being pinned to 0.1.1.

This will likely cause build failures and other issues. The Snyk PR also notes that it failed to update yarn.lock, which is another strong indicator that these changes are problematic.

The vulnerabilities should be addressed by identifying the vulnerable transitive dependencies and updating them, possibly using resolutions in the root package.json, rather than changing these direct dependencies in this way.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/integration-react": "workspace:^",
    "@backstage/plugin-catalog": "workspace:^",
    "@backstage/plugin-techdocs": "workspace:^"

"@backstage/plugin-techdocs-react": "workspace:^",
"@backstage/test-utils": "workspace:^",
"@backstage/theme": "workspace:^",
Expand Down
Loading