Skip to content

[Snyk] Fix for 3 vulnerabilities #12045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 3 vulnerabilities #12045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/test-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/core-app-api": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-react": "workspace:^",
"@backstage/plugin-permission-react": "0.1.0",
Comment on lines +48 to +52
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes appear to be incorrect. They are downgrading packages to very old versions and removing the workspace: specifier, which is likely to break the build and cause regressions. The warning in the PR description 'Failed to update the yarn.lock, please update manually before merging' is another strong indicator that these changes are problematic. For example:

  • @backstage/config is being downgraded from a workspace version (likely 1.0.8 based on the changelog) to 0.1.1.
  • @backstage/core-plugin-api is being downgraded from a workspace version (likely 1.5.3) to 0.1.0.
  • @backstage/plugin-permission-react is being downgraded from a workspace version (likely 0.4.14) to 0.1.0.

These automated changes from Snyk seem to be faulty. I suggest reverting these changes. The vulnerabilities should be addressed by upgrading to compatible versions, not by performing major downgrades.

    "@backstage/config": "workspace:^",
    "@backstage/core-app-api": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/plugin-permission-common": "workspace:^",
    "@backstage/plugin-permission-react": "workspace:^"

"@backstage/theme": "workspace:^",
"@backstage/types": "workspace:^",
"@material-ui/core": "^4.12.2",
Expand Down
Loading