Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/code-coverage/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/core-plugin-api": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly downgrades @backstage/core-plugin-api from the monorepo version (workspace:^, which resolves to 1.5.3 based on the repository's files) to a very old version 0.1.0. This is a critical issue that will likely break the application. This automated change appears to be faulty and should be reverted.

    "@backstage/core-plugin-api": "workspace:^"

"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Similar to the change for @backstage/core-plugin-api, this downgrades @backstage/plugin-catalog-react from the monorepo version (workspace:^) to 0.0.1. This is incorrect and will likely cause issues. The correct fix for the Snyk vulnerabilities is likely to use resolutions in the root package.json to force updates on transitive dependencies, rather than downgrading direct dependencies.

    "@backstage/plugin-catalog-react": "workspace:^"

"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading