Skip to content

[Snyk] Fix for 2 vulnerabilities #12210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #12210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/scaffolder-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/plugin-scaffolder-common": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/types": "0.1.1",
Comment on lines +53 to +56
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes appear to be incorrect for this monorepo setup. Replacing workspace:^ with old, pinned versions for @backstage/plugin-catalog-react and @backstage/types will likely break the build and local development, as it will ignore the local packages in the workspace.

  • @backstage/plugin-catalog-react is being pinned to 0.0.1, which is a significant downgrade.
  • @backstage/types is being pinned to 0.1.1, while the version in the workspace is 1.1.0.

This change should be reverted. The ajv vulnerability that Snyk is trying to fix should be addressed by either updating the direct dependency that brings in the vulnerable version of ajv, or by using a resolutions field in package.json to enforce a secure version of ajv across the workspace.

    "@backstage/plugin-catalog-react": "workspace:^",
    "@backstage/plugin-scaffolder-common": "workspace:^",
    "@backstage/theme": "workspace:^",
    "@backstage/types": "workspace:^"

"@backstage/version-bridge": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand All @@ -74,7 +74,7 @@
"json-schema-library": "^7.3.9",
"lodash": "^4.17.21",
"luxon": "^3.0.0",
"qs": "^6.9.4",
"qs": "^6.14.2",
"react-use": "^17.2.4",
"use-immer": "^0.8.0",
"zen-observable": "^0.10.0",
Expand Down
Loading