Skip to content

[Snyk] Fix for 2 vulnerabilities #12222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #12222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/entity-feedback/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-entity-feedback-common": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/plugin-entity-feedback-common": "0.1.0",
Comment on lines +30 to +35
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated Snyk pull request attempts to fix security vulnerabilities by pinning dependencies to specific, and very old, versions. This is a dangerous approach that will likely break your application and defeats the purpose of using workspace: versions in a monorepo.

The following packages are being significantly downgraded:

  • @backstage/catalog-model: workspace:^ -> 0.1.1
  • @backstage/plugin-catalog-react: workspace:^ -> 0.0.1
  • @backstage/plugin-entity-feedback-common: workspace:^ -> 0.1.0

This will almost certainly introduce breaking changes. The correct way to fix these transitive vulnerabilities is to use resolutions in the root package.json to force a safe version across the entire project.

For example, you could add this to your root package.json:

"resolutions": {
  "ajv": ">=8.12.0",
  "qs": ">=6.11.1"
}

After making this change, you would need to run yarn install to update the yarn.lock file, which this PR failed to do.

It is strongly recommended to close this PR and address the vulnerabilities manually by reverting these changes and applying a proper fix.

Suggested change
"@backstage/catalog-model": "0.1.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-entity-feedback-common": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/plugin-entity-feedback-common": "0.1.0",
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-entity-feedback-common": "workspace:^",

"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.9.13",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading