Skip to content

[Snyk] Fix for 2 vulnerabilities #12337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #12337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions plugins/search-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,23 +36,23 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-openapi-utils": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-openapi-utils": "0.0.1",
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-auth-node": "0.6.0",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-node": "workspace:^",
"@backstage/plugin-search-backend-node": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-backend-node": "0.1.2",
"@backstage/plugin-search-common": "0.3.1",
Comment on lines +39 to +48
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change introduces an inconsistency in how @backstage dependencies are managed. Some packages are now pinned to specific versions, while others like @backstage/config, @backstage/errors, etc., still use workspace:^. It's generally better to be consistent. Either all @backstage packages in this package.json should be pinned, or they should all use workspace:^ to inherit versions from the monorepo root. Since this is a monorepo setup, using workspace:^ is the idiomatic approach. Pinning versions here can lead to version conflicts and maintenance overhead. I recommend reverting these to use workspace:^ and managing the versions at the workspace level.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-openapi-utils": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-auth-node": "workspace:^",
    "@backstage/plugin-permission-common": "workspace:^",
    "@backstage/plugin-permission-node": "workspace:^",
    "@backstage/plugin-search-backend-node": "workspace:^",
    "@backstage/plugin-search-common": "workspace:^"

"@backstage/types": "workspace:^",
"@types/express": "^4.17.6",
"dataloader": "^2.0.0",
"express": "^4.17.1",
"express": "^4.22.0",
"express-promise-router": "^4.1.0",
"lodash": "^4.17.21",
"qs": "^6.10.1",
"qs": "^6.14.2",
"winston": "^3.2.1",
"yn": "^4.0.0",
"zod": "^3.21.4"
Expand Down
Loading