Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/scaffolder-backend-module-cookiecutter/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-scaffolder-backend": "workspace:^",
"@backstage/plugin-scaffolder-node": "workspace:^",
"@backstage/integration": "0.1.0",
"@backstage/plugin-scaffolder-backend": "2.1.0",
"@backstage/plugin-scaffolder-node": "0.2.0",
Comment on lines +26 to +31
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Pinning versions of workspace packages like this is not recommended in a monorepo. It bypasses the workspace:^ protocol, which can lead to multiple versions of these packages being installed. This can cause subtle bugs and increases maintenance overhead.

The Snyk PR description also warns: Failed to update the yarn.lock, please update manually before merging. This indicates that the dependency graph is likely inconsistent.

To properly fix the vulnerabilities, consider one of the following approaches:

  • Update packages across the monorepo: Update the versions of the vulnerable packages in their respective package.json files at the root of the monorepo and run yarn to update the lockfile.
  • Use Yarn resolutions: If a direct dependency update isn't feasible, add a resolutions field to the root package.json to force a non-vulnerable version of the transitive dependencies (e.g., ajv, qs).

For now, these changes should be reverted to maintain the integrity of the yarn workspace.

    "@backstage/backend-common": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/integration": "workspace:^",
    "@backstage/plugin-scaffolder-backend": "workspace:^",
    "@backstage/plugin-scaffolder-node": "workspace:^"

"@backstage/types": "workspace:^",
"command-exists": "^1.2.9",
"fs-extra": "10.1.0",
Expand Down
Loading