Skip to content

[Snyk] Fix for 2 vulnerabilities #12340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
+4 −4
Closed

[Snyk] Fix for 2 vulnerabilities #12340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/catalog-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/errors": "0.1.1",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/types": "workspace:^"
Comment on lines +39 to 44
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes incorrectly replace workspace:^ references with pinned versions. In a monorepo using Yarn workspaces, packages should reference each other using workspace:^ to ensure they use the version from the local workspace. Pinning to specific versions like this breaks the monorepo structure and can lead to using stale code or build failures. The PR description's warning about failing to update yarn.lock is a strong indicator that this approach is flawed.

Furthermore, the versions being pinned are inconsistent and likely incorrect:

  • @backstage/catalog-model is downgraded from 1.4.1 to 0.1.1.
  • @backstage/errors is downgraded from 1.2.1 to 0.1.1.
  • @backstage/plugin-catalog-common is downgraded from 1.0.15 to 0.1.0.

This will almost certainly break the application.

To correctly fix the underlying vulnerabilities, the dependencies within the respective workspace packages should be updated (e.g., ajv in @backstage/catalog-model), and then yarn.lock should be regenerated by running yarn. These changes should be reverted.

Suggested change
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/errors": "0.1.1",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/types": "workspace:^"
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/types": "workspace:^"

},
"devDependencies": {
Expand Down
Loading