Skip to content

[Snyk] Fix for 3 vulnerabilities #12342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 3 vulnerabilities #12342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions plugins/search-backend-module-techdocs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,17 +36,17 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-search-backend-node": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-techdocs-node": "workspace:^",
"@backstage/plugin-search-common": "0.3.1",
"@backstage/plugin-techdocs-node": "1.12.11",
Comment on lines +39 to +49
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Pinning these dependencies to specific versions resolves the immediate security vulnerabilities. However, this change moves away from using the workspace:^ protocol, which is a standard practice in this monorepo.

By pinning versions, this package will no longer use the local, in-repo versions of these dependencies. This can lead to several issues:

  • Version Skew: Other packages in the monorepo may use different versions, leading to inconsistencies.
  • Stale Dependencies: Local changes to these dependencies won't be reflected here, as it will always pull the pinned version from the registry.
  • Maintenance Overhead: It can complicate future dependency management.

A more robust long-term solution would be to update the dependencies across the entire workspace, which would allow you to retain the workspace:^ references and ensure consistency. If you choose to merge this as-is, be mindful of these potential issues.

"lodash": "^4.17.21",
"node-fetch": "^2.6.7",
"p-limit": "^3.1.0",
Expand Down
Loading