Skip to content

[Snyk] Fix for 3 vulnerabilities #12344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 3 vulnerabilities #12344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/techdocs-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@
"ext": "ts"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/catalog-model": "0.1.1",
"@backstage/cli-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-techdocs-node": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/plugin-techdocs-node": "1.12.11",
Comment on lines +63 to +67
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change replaces workspace:^ dependencies with pinned versions. In a monorepo setup, this is incorrect and can lead to significant issues. The workspace:^ protocol ensures that local packages from the monorepo are used, allowing for a consistent development environment. Pinning to specific versions will cause yarn to fetch these packages from the npm registry instead of using the local workspace versions, which can break the build and introduce inconsistencies. The vulnerabilities should be addressed by updating the underlying dependencies or using resolutions in the root package.json, not by pinning workspace packages.

    "@backstage/backend-common": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/cli-common": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/plugin-techdocs-node": "workspace:^"

"@types/dockerode": "^3.3.0",
"commander": "^9.1.0",
"dockerode": "^3.3.1",
Expand Down
Loading