Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/github-pull-requests-board/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This dependency should use workspace:^ to reference the local package in the monorepo, not a pinned outdated version. This change introduces a significant downgrade from the workspace version 1.4.1 to 0.1.1.

Suggested change
"@backstage/catalog-model": "0.1.1",
"@backstage/catalog-model": "workspace:^",

"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/integration": "0.1.0",
"@backstage/plugin-catalog-react": "0.0.1",
Comment on lines +40 to +41
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependencies should use workspace:^ to reference the local packages in the monorepo, not pinned outdated versions. These changes introduce significant downgrades and break from the monorepo package referencing strategy.

Suggested change
"@backstage/integration": "0.1.0",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",

"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading